NUI 6263 search component accessibility#801
Merged
Conversation
Contributor
pavlo-poimanov
left a comment
pavlo-poimanov
left a comment
There was a problem hiding this comment.
image/popup/repeat should be fine but the search I'm not sure this changes will not cause problems. double check if all fine then ok.
also you can be a good camper and do next:
- make this true standalone components
- rewrite to signals control flow
- ngDestory => destroyRef
- inject() function
first camp fire rule - leave place better than it was before you ;)
pavlo-poimanov
previously approved these changes
Jan 26, 2026
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
db8d179 to
a7cca60
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
a7cca60 to
02e3e7d
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
12 times, most recently
from
3fe7590 to
9477fd0
Compare
Contributor
|
@ludmilaFialova , I recommend closing this one and start from the beginning by splitting the changes. |
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
2 times, most recently
from
380d523 to
5af4327
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
2 times, most recently
from
0db4cd8 to
2e6c872
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
2e6c872 to
0fd2af0
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
1b3a33c to
dc2ee2f
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
from
135f660 to
a3504a5
Compare
| await menu.isMenuClosed(); | ||
| await menu.isMenuOpened(); | ||
| // First menu item should be active | ||
| expect(await menu.getMenuItemByIndex(0).isActiveItem()).toBe(true); |
Contributor
There was a problem hiding this comment.
better to have toBeActiveItemSelected...
Contributor
There was a problem hiding this comment.
don't understand why it was needed to change it
Contributor
pavlo-poimanov
left a comment
pavlo-poimanov
left a comment
There was a problem hiding this comment.
looks fine , packadge-lock is not needed because we use yarn
pavlo-poimanov
approved these changes
Apr 23, 2026
Contributor
pavlo-poimanov
left a comment
pavlo-poimanov
left a comment
There was a problem hiding this comment.
we can remove packadge lock later
erzik987
deleted the
bugfix/NUI-6263-search-component-accessibility_to_main
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://swicloud.atlassian.net/browse/NUI-6263
ER:
The Search button opens a pop-up when the Spacebar key is pressed.
The expanded search bar closes when the Esc key is pressed.
The buttons have sufficient contrast when focused.
The cancel button next to the Search bar is focusable by the Tab key and is called “Clear search button”
The magnifier icon next to the Search bar is hidden for the screen reader.
The buttons in the “Recent searches” area are accessible by the Tab key. I can get to the search by pressing the Enter or Space bar key. The caret-right icon is hidden.
When returning to some text in the search field, I hear: “Search edit selected all”
https://swicloud.atlassian.net/browse/OO-55517
ER:
The icon will be hidden for the SR. There will be no error in AXE DevTool.
Checklist