fix: correct Kanji character detection#400
Open
ren1244 wants to merge 1 commit intosoldair:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered the same issue as described in #173.
After reviewing the source code, I found that the problem was caused by an incorrect Unicode range check for Kanji characters.
This pull request fixes that issue.
For example, given the input string:
兩個黃鸝鳴翠柳It should be segmented as:
兩個黃鸝鳴翠柳In the previous version,
黃鸝was mistakenly classified as Kanji, but these characters are not Kanji.