Fix missing bundle issues for browsers#402
Open
cinderblock wants to merge 3 commits intosoldair:masterfrom
Open
Fix missing bundle issues for browsers#402cinderblock wants to merge 3 commits intosoldair:masterfrom
cinderblock wants to merge 3 commits intosoldair:masterfrom
Conversation
Fixes soldair#333 soldair#335 soldair#346 soldair#362 soldair#355 soldair#363 soldair#394 `.gitignore` was being used by npm instead of `.npmignore` causing the build dir to be ignored. See https://stackoverflow.com/questions/40528053/npm-install-and-build-of-forked-github-repo/57829251#57829251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of issues have been cropping up about this. This should fix all of them.
#333
#335
#346
#362
#355
#363
#394