Removes duplicate search results from search, and fix incorrect URLs#1320
Merged
LadyBluenotes merged 3 commits intosolidjs:mainfrom Oct 28, 2025
Merged
Removes duplicate search results from search, and fix incorrect URLs#1320LadyBluenotes merged 3 commits intosolidjs:mainfrom
LadyBluenotes merged 3 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LadyBluenotes
approved these changes
Oct 28, 2025
2 tasks
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
Removes duplicated search results and fix incorrect URLs from Orama search results.
For example "router" gives two duplicated documents
solid-router/index#solid-router(invalid)solid-router#solid-router(valid)The underlying problem seems to be we use mostly urls that do not contain trailing slashes, but our main sections "Solid Router", "Solid Meta", and "Solid Start" are linked using a trailing slash from the top bar menu. This probably confuses orama index resulting in a link that includes
/indexas thepathof the document. Im actually not sure but thats what I suspect.Related issues & labels