Improve createEffect and createRenderEffect reference#1330
Merged
LadyBluenotes merged 15 commits intosolidjs:mainfrom Nov 9, 2025
Merged
Improve createEffect and createRenderEffect reference#1330LadyBluenotes merged 15 commits intosolidjs:mainfrom
createEffect and createRenderEffect reference#1330LadyBluenotes merged 15 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
amirhhashemi
force-pushed
the
improve-effect-reference
branch
from
73217bb to
a50d1ff
Compare
titoBouzout
requested changes
Nov 4, 2025
src/routes/reference/secondary-primitives/create-render-effect.mdx
Outdated
Show resolved
Hide resolved
src/routes/reference/secondary-primitives/create-render-effect.mdx
Outdated
Show resolved
Hide resolved
Collaborator
|
Theres a small issue with the bullets not being rendered in "Execution Timing", https://deploy-preview-1330--solid-docs.netlify.app/reference/secondary-primitives/create-render-effect |
Collaborator
Author
|
@titoBouzout I updated the structure again and added a little more detail about SSR. |
titoBouzout
approved these changes
Nov 8, 2025
Collaborator
|
@amirhhashemi Thanks, the structure looks great and the content seems clear to me. |
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
createEffectandcreateRenderEffectreference pages by:Any important notes removed from the reference pages (usually for Diataxis compliance) have been moved to an explanation page.