Skip to content

Fix Devise 5 compatibility: replace deprecated positional scope in sign_in #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antonzaytsev wants to merge 2 commits into from
Closed

Fix Devise 5 compatibility: replace deprecated positional scope in sign_in #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb8b4c
Replace deprecated positional scope arg in sign_in call
antonzaytsev Apr 8, 2026
7b7e2da
Bump version to 2.6.1
antonzaytsev Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/controllers/frontend/spree/user_registrations_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def create
build_resource(spree_user_params)
if resource.save
set_flash_message(:notice, :signed_up)
sign_in(:spree_user, resource)
sign_in(resource)
session[:spree_user_signup] = true
respond_with resource, location: after_sign_up_path_for(resource)
else
Expand All @@ -41,4 +41,4 @@ def check_permissions
def spree_user_params
params.require(:spree_user).permit(Spree::PermittedAttributes.user_attributes | [:email])
end
end
end
4 changes: 2 additions & 2 deletions lib/solidus_auth_devise/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module SolidusAuthDevise
VERSION = "2.6.0"
end
VERSION = "2.6.1"
end