Skip to content

refactor: break the Python wrapping code in universe/ to different files by shape dimension #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yungyuc merged 8 commits into from
Mar 28, 2026
Merged

refactor: break the Python wrapping code in universe/ to different files by shape dimension #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c2963d4
Extract `WrapPoint3d` and `WrapPointPad` to a distinct file
yungyuc Mar 28, 2026
5d88220
Extract `WrapSegment3d` and `WrapSegmentPad` to a distinct file
yungyuc Mar 28, 2026
9f9ea40
Extract `WrapBezier3d` and `WrapCurvePad` to `wrap_shape1d.cpp`
yungyuc Mar 28, 2026
f19c79d
Extract `WrapTriangle3d` and `WrapTrianglePad` to `wrap_polygon.cpp`
yungyuc Mar 28, 2026
32d5948
Extract `WrapBoundBox3d` to a distinct file
yungyuc Mar 28, 2026
7aaf633
Refactor `WrapPolygonPad` in the same way `WrapTrianglePad`
yungyuc Mar 28, 2026
d20bff2
Rename `wrap_polygon.cpp` to `wrap_shape2d.cpp`
yungyuc Mar 28, 2026
c27f9f7
Remove `wrap_bernstein.cpp`
yungyuc Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/modmesh/universe/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ set(MODMESH_UNIVERSE_PYMODHEADERS

set(MODMESH_UNIVERSE_PYMODSOURCES
${CMAKE_CURRENT_SOURCE_DIR}/pymod/universe_pymod.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_bernstein.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_shape0d.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_shape1d.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_shape2d.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_shape3d.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_World.cpp
${CMAKE_CURRENT_SOURCE_DIR}/pymod/wrap_polygon.cpp
CACHE FILEPATH "" FORCE)

set(MODMESH_UNIVERSE_FILES
Expand Down
6 changes: 4 additions & 2 deletions cpp/modmesh/universe/pymod/universe_pymod.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ void initialize_universe(pybind11::module & mod)
{
auto initialize_impl = [](pybind11::module & mod)
{
wrap_bernstein(mod);
wrap_shape0d(mod);
wrap_shape1d(mod);
wrap_shape2d(mod);
wrap_shape3d(mod);
wrap_World(mod);
wrap_polygon(mod);
};

OneTimeInitializer<bernstein_pymod_tag>::me()(mod, initialize_impl);
Expand Down
6 changes: 4 additions & 2 deletions cpp/modmesh/universe/pymod/universe_pymod.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ namespace python
{

void initialize_universe(pybind11::module & mod);
void wrap_bernstein(pybind11::module & mod);
void wrap_shape0d(pybind11::module & mod);
void wrap_shape1d(pybind11::module & mod);
void wrap_shape2d(pybind11::module & mod);
void wrap_shape3d(pybind11::module & mod);
void wrap_World(pybind11::module & mod);
void wrap_polygon(pybind11::module & mod);

} /* end namespace python */

Expand Down
Loading
Loading