Frontend1#7
Conversation
hopefully it works
Added instruction to use an empty passphrase for SSH key generation.
…e explicit, changed return info for package creation api
This is directly taking all diff between frontend2 and @ASROYAL work
There was a problem hiding this comment.
Do not rename variables, verbose names are for clarity.
Do not use default argument with datetime.now
This argument is evaluated ONCE at initialisation and will not be updated before every run.
Justify the changes in length for the character arrays in token hash etc. these have been turned for their respective hashing algorithm and should not be changed unless the underlying code has been changed
User.id should be an index. We search our database mainly using user id.
There was a problem hiding this comment.
What is this for? Not needed. Remove.
There was a problem hiding this comment.
Don't hardcode values like this. Create a script that imports and sql database file instead and load your dummy data into that. It is far more modular and easier to read.
There was a problem hiding this comment.
Why even change this? What is the reason for it? Remove changes
There was a problem hiding this comment.
Why this? Remove, we build from the main docker compose file in backend/Docker
There was a problem hiding this comment.
Why is there a zip file ? Remove.
There was a problem hiding this comment.
Why is this here? This belongs in integration.md if anywhere. Besides this is just parroted stuff from readme.md duplicate, remove
There was a problem hiding this comment.
version: tag is depreciated
We already have a proper compose file embedded in the readme.md
There was a problem hiding this comment.
Why a zip file? Remove
There was a problem hiding this comment.
Don't change, the one on main is upto date
There was a problem hiding this comment.
This does not even include all required dependency. To make a proper requirement file, build on python 3.14 and install all requirements with pip
Then run pip freeze
There was a problem hiding this comment.
Why rename all the comments? Tell me the changes required, I will make them myself. This is unnecessary and already outdated, main branch already has most of these changes
There was a problem hiding this comment.
Why are you changing this file? We use different hash types based on performance vectors and security requirements. Remove changes
There was a problem hiding this comment.
Since we are not doing calculation based on more package parameters, cost of package does not change. Hence this still should still use an lru_cache.
The new function should be implemented by creating a new graph combining the time and cost graphs with given weightage.
So it would look like:
For time, cost in zip(time_graph, cost_graph):
New_graph.add(time_graph * 0.5 + cost_grapg * 0.5)2 participants
No description provided.