fix: reorder test data generation and fix CLI prompts#39
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
soniapi
force-pushed
the
fix-interactive-prompts-14515451615286468059
branch
from
f44c8cc to
651e7a4
Compare
- Moved test data generation and insertion logic before `helpers::prompt_microstructure_variable` in `tests/integration_test.rs` so data is present for min/max calculations. - Modified `prompt_microstructure_variable` and `prompt_cutoff_value` in `src/helpers.rs` to use `print!` and `io::stdout().flush().unwrap()` to properly render prompts inline before waiting for user input, fixing issues with hidden/delayed standard output on interactive shells. Co-authored-by: soniapi <396009+soniapi@users.noreply.github.com>
soniapi
force-pushed
the
fix-interactive-prompts-14515451615286468059
branch
from
b7ae627 to
9d88598
Compare
- Removes manual dropping and re-creating of temporary partition tables. Uses the default `objects_s_100000_below` and `objects_s_100000_above` tables created implicitly by the initial migrations to receive the test data. - Ensures the default partitions are successfully detached using their exact migration names (`objects_s_100000_below`) before the user's explicit partition request (`180000.0`) runs, preventing `relation does not exist` test failures while preserving the 200,000 inserted rows for the prompt queries. - Removes locally compiled scratchpad binaries and extraneous debugging source files from the workspace. Co-authored-by: soniapi <396009+soniapi@users.noreply.github.com>
- Modifies the random generation algorithm for `s_val` test data to enforce values never falling directly into the migration gap (`99999.0` to `100000.0`). - Fixes CI test flakiness where batches of 1000 records randomly failed to route and insert because a single generated float hit the unregistered partition boundary, throwing silent PostgreSQL errors. - Guarantees exactly `200000` rows will be inserted, resolving assertion failures. Co-authored-by: soniapi <396009+soniapi@users.noreply.github.com>
1 participant
Resolves bugs where standard output prompts were not properly printing before
io::stdin().read_line()awaited input, preventing users from seeing questions. Additionally reorderstests/integration_test.rsto correctly generate and seed test data before queryinghelpers::prompt_microstructure_variableso min/max bounds can correctly be discovered.PR created automatically by Jules for task 14515451615286468059 started by @soniapi