Add an option to reject/log Smtlib inputs with illegal commands#630
Draft
daniel-raffler wants to merge 9 commits into
Draft
Add an option to reject/log Smtlib inputs with illegal commands#630daniel-raffler wants to merge 9 commits into
daniel-raffler wants to merge 9 commits into
Conversation
# Conflicts: # src/org/sosy_lab/java_smt/SolverContextFactory.java # src/org/sosy_lab/java_smt/solvers/yices2/Yices2FormulaManager.java # src/org/sosy_lab/java_smt/solvers/yices2/Yices2SolverContext.java
Contributor
Author
|
@baierd Should I still split up the option for parsing/dumping? Or is this fine with you? |
Contributor
|
I generally agree with the idea of this PR (adding an option that configures the parser), but i think we should combine this with #621, as the other PR provides an approach that can handle all situations. Note: i think dumping also should have an option in theory, but in practice this is currently not really needed. At least as far as i know. Should be have cases in which we need output that strictly conforms to SMTLIB2s definition, then we should of course do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR extends the Tokenizer to recognize all commands from the SMTLIB standard. We also add a configuration option
parser.illegalInputto let the user decide how to handle illegal commands. Currently, we simply skip over unrecognized/uninteresting commands while parsing. This can hide potential bugs or lead to confusing error messages. With the new option, skipping is still the default behavior. However, it's also possible to log illegal commands or abort the parse entirely by setting the option to a different valueThe idea is to eventually make the Tokenizer strict and always throw an exception. However, we may still have to add more non-standard commands first