-
Notifications
You must be signed in to change notification settings - Fork 174
fix(deps): update react monorepo (major) #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The import of
createRendererfromreact-test-renderer/shallowwill fail because this module is removed in React 19, breaking tests that useshallowRender.Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The update to React 19 introduces a breaking change. The
react-test-renderer/shallowmodule, which is imported insrc/commons/utils/TestUtils.tsto use thecreateRendererfunction, has been completely removed in React 19. As a result, any test that relies on theshallowRenderutility fromTestUtils.tswill fail at runtime with a "module not found" error. This will break a significant portion of the test suite, blocking the CI pipeline.💡 Suggested Fix
Since
react-test-renderer/shallowis removed in React 19, theshallowRenderutility inTestUtils.tsmust be refactored. Consider migrating the affected tests to use a different testing library like@testing-library/reactwhich is generally recommended by the React team over shallow rendering.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID:
7600718