-
Notifications
You must be signed in to change notification settings - Fork 174
chore(deps): update dependency @blueprintjs/datetime to v6.0.10 #3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @blueprintjs/datetime to v6.0.10 #3466
Conversation
Pull Request Test Coverage Report for Build 20276129547Details
💛 - Coveralls |
2d9bed5 to
4ced144
Compare
4ced144 to
7940ff5
Compare
|
|
||
| "@blueprintjs/datetime@npm:^6.0.0": | ||
| version: 6.0.8 | ||
| resolution: "@blueprintjs/datetime@npm:6.0.8" | ||
| version: 6.0.10 | ||
| resolution: "@blueprintjs/datetime@npm:6.0.10" | ||
| dependencies: | ||
| "@blueprintjs/core": "npm:^6.3.4" | ||
| "@blueprintjs/icons": "npm:^6.3.1" | ||
| "@blueprintjs/select": "npm:^6.0.8" | ||
| "@blueprintjs/core": "npm:^6.4.1" | ||
| "@blueprintjs/icons": "npm:^6.3.2" | ||
| "@blueprintjs/select": "npm:^6.0.10" | ||
| classnames: "npm:^2.3.1" | ||
| date-fns: "npm:^2.28.0" | ||
| date-fns-tz: "npm:^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The handleParseDate function in GroundControlEditCell.tsx returns false on failure, but the @blueprintjs/datetime v6.0.10 parseDate prop expects null.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
In GroundControlEditCell.tsx, the handleParseDate function returns false when date parsing fails. However, the parseDate prop for the @blueprintjs/datetime v6.0.10 DateInput component expects a function with the signature (str: string) => Date | null. Returning false instead of the expected null violates the component's API contract. This mismatch can lead to incorrect error handling or other unexpected behavior within the DateInput component, as it may not correctly identify an invalid date parsing attempt.
💡 Suggested Fix
Modify the handleParseDate function in GroundControlEditCell.tsx to return null instead of false when the date string is invalid. Change return date.isValid() ? date.toDate() : false; to return date.isValid() ? date.toDate() : null;.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: yarn.lock#L1512-L1523
Potential issue: In `GroundControlEditCell.tsx`, the `handleParseDate` function returns
`false` when date parsing fails. However, the `parseDate` prop for the
`@blueprintjs/datetime` v6.0.10 `DateInput` component expects a function with the
signature `(str: string) => Date | null`. Returning `false` instead of the expected
`null` violates the component's API contract. This mismatch can lead to incorrect error
handling or other unexpected behavior within the `DateInput` component, as it may not
correctly identify an invalid date parsing attempt.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7599549
This PR contains the following updates:
6.0.8->6.0.10Release Notes
palantir/blueprint (@blueprintjs/datetime)
v6.0.10Compare Source
v6.0.9Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.