Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 7, 2025

This PR contains the following updates:

Package Change Age Confidence
@blueprintjs/datetime (source) 6.0.8 -> 6.0.10 age confidence

Release Notes

palantir/blueprint (@​blueprintjs/datetime)

v6.0.10

Compare Source

v6.0.9

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies This pull request updates dependency files label Dec 7, 2025
@coveralls
Copy link

coveralls commented Dec 7, 2025

Pull Request Test Coverage Report for Build 20276129547

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.773%

Totals Coverage Status
Change from base Build 20276095058: 0.0%
Covered Lines: 4847
Relevant Lines: 11272

💛 - Coveralls

@renovate renovate bot changed the title chore(deps): update dependency @blueprintjs/datetime to v6.0.9 chore(deps): update dependency @blueprintjs/datetime to v6.0.10 Dec 8, 2025
@renovate renovate bot force-pushed the renovate/blueprintjs-datetime-6.x-lockfile branch 2 times, most recently from 2d9bed5 to 4ced144 Compare December 16, 2025 16:46
@renovate renovate bot force-pushed the renovate/blueprintjs-datetime-6.x-lockfile branch from 4ced144 to 7940ff5 Compare December 16, 2025 17:00
Comment on lines 1513 to 1523

"@blueprintjs/datetime@npm:^6.0.0":
version: 6.0.8
resolution: "@blueprintjs/datetime@npm:6.0.8"
version: 6.0.10
resolution: "@blueprintjs/datetime@npm:6.0.10"
dependencies:
"@blueprintjs/core": "npm:^6.3.4"
"@blueprintjs/icons": "npm:^6.3.1"
"@blueprintjs/select": "npm:^6.0.8"
"@blueprintjs/core": "npm:^6.4.1"
"@blueprintjs/icons": "npm:^6.3.2"
"@blueprintjs/select": "npm:^6.0.10"
classnames: "npm:^2.3.1"
date-fns: "npm:^2.28.0"
date-fns-tz: "npm:^2.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The handleParseDate function in GroundControlEditCell.tsx returns false on failure, but the @blueprintjs/datetime v6.0.10 parseDate prop expects null.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

In GroundControlEditCell.tsx, the handleParseDate function returns false when date parsing fails. However, the parseDate prop for the @blueprintjs/datetime v6.0.10 DateInput component expects a function with the signature (str: string) => Date | null. Returning false instead of the expected null violates the component's API contract. This mismatch can lead to incorrect error handling or other unexpected behavior within the DateInput component, as it may not correctly identify an invalid date parsing attempt.

💡 Suggested Fix

Modify the handleParseDate function in GroundControlEditCell.tsx to return null instead of false when the date string is invalid. Change return date.isValid() ? date.toDate() : false; to return date.isValid() ? date.toDate() : null;.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: yarn.lock#L1512-L1523

Potential issue: In `GroundControlEditCell.tsx`, the `handleParseDate` function returns
`false` when date parsing fails. However, the `parseDate` prop for the
`@blueprintjs/datetime` v6.0.10 `DateInput` component expects a function with the
signature `(str: string) => Date | null`. Returning `false` instead of the expected
`null` violates the component's API contract. This mismatch can lead to incorrect error
handling or other unexpected behavior within the `DateInput` component, as it may not
correctly identify an invalid date parsing attempt.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7599549

@RichDom2185 RichDom2185 merged commit 1005b77 into master Dec 16, 2025
11 checks passed
@RichDom2185 RichDom2185 deleted the renovate/blueprintjs-datetime-6.x-lockfile branch December 16, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies This pull request updates dependency files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants