fix(web): fix line numbers selectable in Safari#1037
Merged
brendan-kellam merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
Add WebkitUserSelect: 'none' to prevent line numbers from being selected on Safari, which requires the -webkit-user-select vendor prefix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdds an optional hover-visible copy button to the lightweight code highlighter, groups line numbers and code into per-line containers, prevents selecting gutter line numbers in WebKit, and documents the changes in the changelog. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant UI as CodeBlock UI
participant Highlighter as LightweightCodeHighlighter
participant Clipboard as Navigator.clipboard
User->>UI: Hover code block
UI->>Highlighter: Show CopyIconButton (if isCopyButtonVisible)
User->>Highlighter: Click Copy button
Highlighter->>Clipboard: writeText(code)
Clipboard-->>Highlighter: success / failure
Highlighter-->>UI: show copy confirmation / error
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds an optional isCopyButtonVisible prop (default false) that renders a copy-to-clipboard button in the top-right corner, visible on hover. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LightweightCodeHighlighterwere selectable in Safari-webkit-user-selectvendor prefix (WebkitUserSelectin React inline styles) in addition to the standarduserSelectpropertyWebkitUserSelect: 'none'to the line number span styleTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit