fix(backend): abort GitLab sync on non-404 API errors to prevent repo deletion#1039
Merged
brendan-kellam merged 2 commits intomainfrom Mar 24, 2026
Merged
fix(backend): abort GitLab sync on non-404 API errors to prevent repo deletion#1039brendan-kellam merged 2 commits intomainfrom
brendan-kellam merged 2 commits intomainfrom
Conversation
… deletion Previously, any HTTP error from the GitLab API (including 500s) was converted to a warning and the sync continued with a partial repo list. This caused the database reconciliation to delete repos from the failed group/user/project. Now only 404 errors are treated as warnings (resource not found or no access); all other errors abort the sync so the database is left untouched. Fixes #1029 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughFixed GitLab API error handling to prevent unintended repository deletion when non-404 errors (e.g., HTTP 500) occur during group/user/project lookups. The code now distinguishes between 404 errors (treated as warnings) and other errors (rethrown), preventing silent fallthrough that caused data loss. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RepoToConnectionrecords and only re-created repos from the partial list, effectively orphaning repos from the failed group/user/projectgithub.tsFixes #1029
🤖 Generated with Claude Code
Summary by CodeRabbit