add pure docker deploy script for syntactic-code-intel-worker#1213
Conversation
| -e PRECISE_CODE_INTEL_UPLOAD_AWS_ENDPOINT=http://blobstore:9000 \ | ||
| -e 'OTEL_EXPORTER_OTLP_ENDPOINT=http://otel-collector:4317' \ | ||
| -e 'SYNTACTIC_CODE_INTEL_WORKER_ADDR=:3288' \ | ||
| index.docker.io/sourcegraph/syntactic-code-intel-worker:6.1.1295@sha256:c6e2b097b8f16394e339588e208c43587f1fa6a35cb44e9759622c448ddc1445 |
There was a problem hiding this comment.
Since we're pinning a SHA here, do we need to go in and update it on every release?
If so, do we need to update any release checklists for doing so?
There was a problem hiding this comment.
We don't actually maintain up to date shas here. Check the release tags to see: https://github.com/sourcegraph/deploy-sourcegraph-docker/blob/v6.3.0/pure-docker/deploy-frontend.sh
It might be worth a later PR to fix this up though, and I'm thinking of adding a test to the pipeline to ensure that services defined in the docker-compose.yaml have a corresponding file here.
| -e SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090 \ | ||
| -e PRECISE_CODE_INTEL_UPLOAD_BACKEND=blobstore \ | ||
| -e PRECISE_CODE_INTEL_UPLOAD_AWS_ENDPOINT=http://blobstore:9000 \ | ||
| -e 'OTEL_EXPORTER_OTLP_ENDPOINT=http://otel-collector:4317' \ | ||
| -e 'SYNTACTIC_CODE_INTEL_WORKER_ADDR=:3288' \ |
There was a problem hiding this comment.
Why are some of these quoted and others not? Let's be consistent unless there is a specific reason to not be.
There was a problem hiding this comment.
Good catch, I think the reason its inconsistent is just that some of the other shell scripts are inconsistent here and I used amp to generate it from reference
Co-authored-by: Varun Gandhi <varun.gandhi@sourcegraph.com>
DaedalusG
deleted the
wg/rel/updated-pure-docker-syntactic-code-intel-worker
branch
2 participants
Closes https://linear.app/sourcegraph/issue/REL-993/syntactic-code-intel-worker-container-on-pure-docker-deployment
Add a pure docker deploy script corresponding to the service definition in
docker-compose.yamlTest plan
Tested locally with
podmanensuring that the container comes up with expected properties