Skip to content

chore: handle batch spec v3 #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bahrmichael merged 4 commits into from
Apr 30, 2026
+7 −2
Merged

chore: handle batch spec v3 #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65ca47c
Agentic Batch Change
bahrmichael Apr 30, 2026
7e5c190
fix
bahrmichael Apr 30, 2026
d5c74a4
Update service.go
bahrmichael Apr 30, 2026
7e16998
Update service_test.go
bahrmichael Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ bazel-zoekt
bazel-src-cli
.DS_Store
samples
.amp
4 changes: 4 additions & 0 deletions cmd/src/batch_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,10 @@ func executeBatchSpec(ctx context.Context, opts executeBatchSpecOpts) (err error
}
execUI.ParsingBatchSpecSuccess()

if batchSpec.Version == 3 {
return errors.New("batch spec version 3 is not supported for local execution, please run server-side")
}

execUI.ResolvingNamespace()
namespace, err := svc.ResolveNamespace(ctx, opts.flags.namespace)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/batches/service/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ version: 99
name: test-spec
description: A test spec
`,
expectedErr: errors.New("parsing batch spec: version: version must be one of the following: 1, 2"),
expectedErr: errors.New("parsing batch spec: version: version must be one of the following: 1, 2, 3"),
},
{
name: "mount absolute file",
Expand Down
2 changes: 1 addition & 1 deletion lib/batches/schema/batch_spec_stringdata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading