refactor: exclude bink and mss32 fake files, use include of header#57
Conversation
|
Ok, I am a bit confused. Are the fake definition not in scope due to this changes, or do I need to test this? Could it be possible to just import our Fake headers from the project here into Ghidra without adding it to the export, use the structs and values from there and remove the Fake structure inside the Crusader folder in Ghidra completely? |
|
Hmmm, what I wanted to happen is that those Fake files are deleted, as including Mss32.h would be enough to cover all relevant reimplementations, right? So everything in the /Mss32/ folder in this PR can be removed, right? So, for example, this usage is now correct, right? |
|
I cleaned up the bink and miles files (and directplay files) we don't need from the export from Ghidra as we have sufficient header files ourselves. Can you confirm this PR works and solves your issue? @TheRedDaemon See previous comment clarifying what is happening. |
TheRedDaemon
left a comment
There was a problem hiding this comment.
Looks good. I will merge it and try it in the other branch.
Addresses the miles (and bink issues) mentioned in #56
Note namespace
msschanged toMSS,SND_SoundSystemObjchanged toDAT_SoundSystemStateNamespace
_enumschanged toenums