Add support for SameSite=X & __Secure- / __Host- prefixes#39
Open
geoffyoungs wants to merge 1 commit into
Open
Add support for SameSite=X & __Secure- / __Host- prefixes#39geoffyoungs wants to merge 1 commit into
geoffyoungs wants to merge 1 commit into
Conversation
Currently if a site specifies SameSite=None in the cookie, it will be lost when HTTP::Cookie.parse parses it. This PR adds support for parsing, preserving and restoring, via HTTP::Cookie#set_cookie_value the SameSite=X attribute. It also respects the __Secure- and __Host- prefixes and rejects cookies that violate the spec. Sources: - https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#samesite_attribute - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#cookie_prefixes - https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-cookie-prefixes
knu
requested changes
Apr 6, 2026
| # RFC 6265 5.2.5, 5.2.6 | ||
| avalue = true | ||
| when 'samesite' | ||
| avalue = avalue.downcase |
Member
There was a problem hiding this comment.
I think SameSite values are normally capitalized.
Suggested change
| avalue = avalue.downcase | |
| avalue = avalue.capitalize |
| attr_reader :same_site | ||
|
|
||
| def same_site=(value) | ||
| @same_site = value.downcase |
Member
There was a problem hiding this comment.
Nil should be accepted, and strings should be capitalized.
Suggested change
| @same_site = value.downcase | |
| @same_site = value&.capitalize |
Comment on lines
+586
to
597
| when same_site.eql?('none') | ||
| secure? && (URI::HTTPS === @origin) | ||
| when secure_prefix? | ||
| secure? && (URI::HTTPS === @origin) | ||
| when host_prefix? | ||
| secure? && (URI::HTTPS === @origin) && | ||
| @path == '/' && | ||
| !for_domain? | ||
| when @origin.nil? | ||
| true | ||
| else | ||
| acceptable_from_uri?(@origin) |
Member
There was a problem hiding this comment.
The acceptable_from_uri? check should not be omitted in those cases.
Suggested change
| when same_site.eql?('none') | |
| secure? && (URI::HTTPS === @origin) | |
| when secure_prefix? | |
| secure? && (URI::HTTPS === @origin) | |
| when host_prefix? | |
| secure? && (URI::HTTPS === @origin) && | |
| @path == '/' && | |
| !for_domain? | |
| when @origin.nil? | |
| true | |
| else | |
| acceptable_from_uri?(@origin) | |
| when @origin.nil? | |
| true | |
| when !acceptable_from_uri?(@origin) | |
| false | |
| when same_site == 'None' || secure_prefix? | |
| secure? && (URI::HTTPS === @origin) | |
| when host_prefix? | |
| secure? && (URI::HTTPS === @origin) && | |
| @path == '/' && !for_domain? | |
| else | |
| true |
| # Domain must not be set | ||
| url = URI 'https://www.example.com/' | ||
|
|
||
| tld_cookie1 = HTTP::Cookie.new(cookie_values(:name => '__Host-Foo', :path => '', :secure => true, :domain => 'www.example.com', :origin => url)) |
Member
There was a problem hiding this comment.
I think you mean :path => '/', and you may be missing a test case with for_domain? == true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a site specifies SameSite=None etc in the set-cookie header, it will be lost when HTTP::Cookie.parse parses it.
This PR adds support for parsing, preserving and restoring, via HTTP::Cookie#set_cookie_value the SameSite=X attribute.
It also respects the __Secure- and __Host- prefixes and rejects cookies that violate the spec.
Sources: