Add node affinity and tolerations support#114
Open
groundsada wants to merge 1 commit intospegel-org:mainfrom
Open
Add node affinity and tolerations support#114groundsada wants to merge 1 commit intospegel-org:mainfrom
groundsada wants to merge 1 commit intospegel-org:mainfrom
Conversation
Author
|
Hi @phillebaba can you please look at this and see if the daemonset can be extended? We run a very heterogenous cluster and we can benefit from granular per-node benchmarks for spegel and are happy to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for node affinity and tolerations to improve benchmark scheduling on large clusters with heterogeneous nodes.
Problem
The benchmark tool was experiencing scheduling issues on large clusters where pods would get stuck on incompatible nodes (control plane, tainted nodes, etc.), leading to incomplete benchmark runs.
Solution
--affinity-fileand--tolerations-fileCLI flagsChanges
Usage
benchmark measure \ --output-dir ./results \ --kubeconfig ~/.kube/config \ --namespace seam \ --images ghcr.io/spegel-org/benchmark:v1-10MB-1 ghcr.io/spegel-org/benchmark:v2-10MB-1 \ --affinity-file ./affinity.yaml \ --tolerations-file ./tolerations.yamlTesting
Successfully tested on a 256-node cluster, achieving 120/120 pods scheduled correctly with proper node selection.
Backward Compatibility
✅ Fully backward compatible - existing functionality unchanged when flags are not provided
Acknowledgement