Skip to content

fix(update): close response body and file on error paths #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nghiphaam wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix(update): close response body and file on error paths #3829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d78f38
close resp2.Body and out before Fatal calls
nghiphaam Apr 21, 2026
05ef30e
add out.Close() in io.Copy error path
nghiphaam Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cmd/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,24 @@ func Update(currentVersion string) bool {

resp2, err := http.Get(assetURL)
if err != nil {
out.Close()
spinner.Fail("Failed to download Spicetify")
utils.Fatal(err)
}
defer resp2.Body.Close()

if resp2.StatusCode != http.StatusOK {
resp2.Body.Close()
out.Close()
spinner.Fail("Failed to download Spicetify")
utils.Fatal(fmt.Errorf("unexpected HTTP status: %s for %s", resp2.Status, assetURL))
}

defer resp2.Body.Close()

_, err = io.Copy(out, resp2.Body)
if err != nil {
resp2.Body.Close()
out.Close()
spinner.Fail("Failed to download Spicetify")
utils.Fatal(err)
}
Comment thread
nghiphaam marked this conversation as resolved.
Expand Down