feat: support supplemental bundle path for vault upstream authority#6616
Closed
heybronson wants to merge 2 commits intospiffe:mainfrom
Closed
feat: support supplemental bundle path for vault upstream authority#6616heybronson wants to merge 2 commits intospiffe:mainfrom
heybronson wants to merge 2 commits intospiffe:mainfrom
Conversation
heybronson
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
Collaborator
Did you actually notice this behaviour in practice? The old CA shouldn't be removed immediately, it should still stay in the bundle while it is in use and for at least 24h after that. |
Collaborator
|
Hi @heybronson, just checking in if you had some time to look at this comment |
Collaborator
|
@heybronson , we'll close this for now, if you're still interested in this, please reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Vault upstream authority plugin
Description of change
This PR adds
supplemental_bundle_pathsupport to the Vault upstream authority plugin, enabling graceful root CA rotation.Currently, the Vault plugin only includes the current root CA in the trust bundle. When the root CA rotates, workloads with certificates signed by the old root can no longer validate because the old root is immediately replaced. This makes root CA rotation disruptive.
The new
supplemental_bundle_pathconfiguration option allows operators to specify a PEM file containing additional root CA certificates to include in the trust bundle. This mirrors the existing implementation in the AWS PCA upstream authority plugin.Which issue this PR fixes
related to: #5101