Remove selectors from agent logs#6732
Merged
sorindumitru merged 2 commits intospiffe:mainfrom Mar 11, 2026
Merged
Conversation
sorindumitru
requested review from
MarcosDY,
amartinezfayo,
evan2645 and
rturner3
as code owners
sorindumitru
force-pushed
the
remove-selectors-from-logs
branch
from
ae0de27 to
b218792
Compare
This reverts commit 3138c02. Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
force-pushed
the
remove-selectors-from-logs
branch
from
b218792 to
d5707c0
Compare
Member
amartinezfayo
left a comment
amartinezfayo
left a comment
There was a problem hiding this comment.
Thank you @sorindumitru!
| // If the client times out before all workload attestation plugins have reported selectors or an error, | ||
| // it can be helpful to see the partial set of selectors discovered for debugging purposes. | ||
| log.WithField(telemetry.PartialSelectors, selectors).Error("Timed out collecting selectors for PID") | ||
| log.Error("Timed out collecting selectors for PID") |
Member
There was a problem hiding this comment.
The comment above still says "it can be helpful to see the partial set of selectors discovered for debugging purposes," but this PR removes that. I think it's worth updating or removing that comment.
sorindumitru
force-pushed
the
remove-selectors-from-logs
branch
from
d5707c0 to
a5d533e
Compare
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
iamP1
pushed a commit
to iamP1/spire
that referenced
this pull request
Mar 16, 2026
* Revert "Include selectors in 'no identity issued' logs (spiffe#6179)" This reverts commit 3138c02. Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Remove partial selectors logging Signed-off-by: Sorin Dumitru <sorin@returnze.ro> --------- Signed-off-by: Sorin Dumitru <sorin@returnze.ro> Signed-off-by: iamP1 <nhegde@redhat.com>
iamP1
pushed a commit
to iamP1/spire
that referenced
this pull request
Mar 20, 2026
* Revert "Include selectors in 'no identity issued' logs (spiffe#6179)" This reverts commit 3138c02. Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Remove partial selectors logging Signed-off-by: Sorin Dumitru <sorin@returnze.ro> --------- Signed-off-by: Sorin Dumitru <sorin@returnze.ro> Signed-off-by: iamP1 <nhegde@redhat.com> Signed-off-by: iamP1 <nhegde@redhat.com>
iamP1
pushed a commit
to iamP1/spire
that referenced
this pull request
Mar 20, 2026
* Revert "Include selectors in 'no identity issued' logs (spiffe#6179)" This reverts commit 3138c02. Signed-off-by: Sorin Dumitru <sorin@returnze.ro> * Remove partial selectors logging Signed-off-by: Sorin Dumitru <sorin@returnze.ro> --------- Signed-off-by: Sorin Dumitru <sorin@returnze.ro>Signed-off-by: iamP1 <nhegde@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selectors can contain all sorts of information, it's probably best to never log the full set of discovered selectors from plugins. There is still one more place which logs it at debug level, which should be ok since they are useful for debugging.