Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for URLs and tooltips to your Graphviz plugin. Basically, I'm calling dot with "-Tcmapx" to create a html image map. One big problem with image maps is that they have to match the displayed image. Since the browser might rescale the image, I had to add a javascript library to update the map on the fly: https://github.com/davidjbradshaw/imagemap-resizer
I removed the server-side resizing of images, because this saves me from having to resize the map on the server as well. Hence, the plugin now relies entirely on the browser for resizing the image.