filter out any unexpected GET parametres.#20
Open
schplurtz wants to merge 1 commit intosplitbrain:masterfrom
schplurtz:farm-compat
Open
filter out any unexpected GET parametres.#20schplurtz wants to merge 1 commit intosplitbrain:masterfrom schplurtz:farm-compat
schplurtz wants to merge 1 commit intosplitbrain:masterfrom
schplurtz:farm-compat
Conversation
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7. This is the changes that was proposed in #7.
This PR makes sure unexpected GET parameters are filtered out before the md5 of the requested image is computed. With this patch applied, md5 is computed exactly with the same GET parameters that were used to create it.