TestTcpSocketWriter.TestEventsQueuedWhileWaitingForInitialConnection was false positive#16
Open
delixfe wants to merge 1 commit intosplunk:masterfrom
Open
TestTcpSocketWriter.TestEventsQueuedWhileWaitingForInitialConnection was false positive#16delixfe wants to merge 1 commit intosplunk:masterfrom
delixfe wants to merge 1 commit intosplunk:masterfrom
Conversation
…was false positive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the TcpSocketWriter cannot connect to the server then it blocks the calling thread until it can connect...
According to the unit test TestEventsQueuedWhileWaitingForInitialConnection that should not happen. But the unit test was a false positive. It opened a listener to extract the port number, but never closed the listener. Thus a listener was available ...