Revert "Fix app_tel_for_sok app.conf install stanza header (#1724)"

[vivekr-splunk]

This reverts commit 7fa8698921a131ac7f120d8afb57a5e82d55f60c from PR #1724.

Reason:

• Push workflows on develop started failing at workflow startup (no jobs created) after Fix app_tel_for_sok app.conf install stanza header #1724 merged.
• Fix app_tel_for_sok app.conf install stanza header #1724 bundled workflow secret-guard changes together with the telemetry app change, so this revert restores a healthy baseline first.

After this revert merges, I will recreate a clean PR with only the intended telemetry app fix in pkg/splunk/enterprise/names.go.

[Copilot]

Pull request overview

This PR reverts commit 7fa8698921a131ac7f120d8afb57a5e82d55f60c from PR #1724, which bundled two distinct changes together: a telemetry app.conf fix and workflow secret-guard conditions. The revert is necessary because the workflow changes caused push workflows on the develop branch to fail at startup (no jobs created). By reverting the entire PR, the codebase returns to a stable baseline, allowing the telemetry app fix to be reapplied separately in a follow-up PR.

Changes:

• Reverts telemetry app shell command changes in pkg/splunk/enterprise/names.go (changing back from printf '%s' to echo -e)
• Removes if conditionals that checked for empty secrets in 5 workflow files

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/splunk/enterprise/names.go	Reverts telemetry app creation commands from printf '%s' back to echo -e for both SHC and non-SHC scenarios
.github/workflows/prodsec-workflow.yml	Removes the if: ${{ secrets.FOSSA_API_TOKEN != '' }} condition from FOSSA Test step
.github/workflows/distroless-build-test-push-workflow.yml	Removes the if: ${{ secrets.COVERALLS_TOKEN != '' }} condition from Code Coverage step
.github/workflows/build-test-push-workflow.yml	Removes the if: ${{ secrets.COVERALLS_TOKEN != '' }} condition from Code Coverage step
.github/workflows/arm-Ubuntu-build-test-push-workflow.yml	Removes the if: ${{ secrets.COVERALLS_TOKEN != '' }} condition from Code Coverage step
.github/workflows/arm-AL2023-build-test-push-workflow-AL2023.yml	Removes the if: ${{ secrets.COVERALLS_TOKEN != '' }} condition from Code Coverage step

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.