spike: reduce Monitoring Console restart churn from ConfigMap metadata updates#1731
Open
vivekr-splunk wants to merge 2 commits intodevelopfrom
Open
spike: reduce Monitoring Console restart churn from ConfigMap metadata updates#1731vivekr-splunk wants to merge 2 commits intodevelopfrom
vivekr-splunk wants to merge 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes Monitoring Console (MC) pod restart behavior during C3-style bring-up by switching from ConfigMap resourceVersion tracking to deterministic data hashing. This prevents unnecessary MC restarts when only ConfigMap metadata changes (not actual data).
Changes:
- Replaced ConfigMap resourceVersion with SHA256 data hash for the
monitoringConsoleConfigRevannotation - Added deterministic hash function that sorts keys to ensure consistent output regardless of map iteration order
- Added comprehensive unit tests for hash determinism and statefulset annotation behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/splunk/enterprise/monitoringconsole.go | Implemented getMonitoringConsoleConfigDataHash() function and updated getMonitoringConsoleStatefulSet() to use data hash instead of resourceVersion |
| pkg/splunk/enterprise/monitoringconsole_test.go | Added tests for hash determinism (TestGetMonitoringConsoleConfigDataHash) and integration test verifying statefulset uses data hash (TestGetMonitoringConsoleStatefulSetUsesConfigDataHash) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monitoringConsoleConfigRevto a deterministic hash of MC ConfigMap dataWhy
During C3-style bring-up, MC can restart multiple times. One trigger is that annotation currently follows ConfigMap
resourceVersion, so metadata-only updates can force unnecessary restarts. This spike constrains restarts to effective data changes only.Testing