Update docker-compose configs#789
Open
Ickerday wants to merge 1 commit into
Open
Conversation
Ickerday
force-pushed
the
chore/rename-docker-compose
branch
2 times, most recently
from
23f66a6 to
2f23203
Compare
Ickerday
force-pushed
the
chore/rename-docker-compose
branch
from
2f23203 to
21c373f
Compare
Ickerday
commented
May 20, 2026
| # Copy splunk-mcp-server.tgz, we need to copy entire SDK since | ||
| # splunk-mcp-server.tgz might not exist and we don't want to fail in such case. | ||
| RUN mkdir /tmp/sdk | ||
| # TODO: Despite the comment, I don't get why we need to copy the entire SDK |
Member
There was a problem hiding this comment.
Since you can't dynamically (present or not present) copy a file in Dockerfile. If it didn't exist then it would have failed.
mateusz834
reviewed
May 21, 2026
|
|
||
| RUN /opt/splunk/bin/python3.13 -m venv .venv | ||
| RUN /bin/bash -c "source .venv/bin/activate && LD_LIBRARY_PATH=/opt/splunk/lib python -m pip install '.[openai]' --target=/splunklib-deps" | ||
| RUN /bin/bash -c "LD_LIBRARY_PATH=/opt/splunk/lib /opt/splunk/bin/python3.13 -m pip install '.[openai]' --target=/splunklib-deps" |
Member
There was a problem hiding this comment.
Is this change the fix of the CI? Why this happens?
Python 3.13 was bundled already in previous version of splunk so i don't get the reason here.
Member
There was a problem hiding this comment.
(I think this change is fine, but just curious).
mateusz834
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.