Allow EffectRouter to be passed to Mobius.loop directly#116
Open
JensAyton wants to merge 3 commits intospotify:masterfrom
Open
Allow EffectRouter to be passed to Mobius.loop directly#116JensAyton wants to merge 3 commits intospotify:masterfrom
JensAyton wants to merge 3 commits intospotify:masterfrom
Conversation
Contributor
|
Hmm, I'm not sure about this. I think there are good arguments for both. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 92.30% 92.03% -0.27%
==========================================
Files 46 46
Lines 1442 1456 +14
==========================================
+ Hits 1331 1340 +9
- Misses 111 116 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I missed reviewing this one I think. I’m personally in favor of this approach and eventually removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #114 .
The downside of this approach is that there are now four overloads of
Mobius.loop, which could get nasty if we want to add more dimensions of variants, or just change the interface (for instance, using defaulted arguments instead of the three remainingwithfunctions).I prefer this approach if we view the explicit
Connectableapproach as transitional. If we want to keep all the variants forever, I lean towards #114 .@jeppes @rastersize