Draft
Conversation
andreas-karlsson
changed the title
| uint64 memory_bytes = 7; | ||
|
|
||
| message ResolveLatency { | ||
| option (confidence.api.histogram) = { |
Contributor
Author
There was a problem hiding this comment.
This was cute, but isn't really needed any longer cause we resample the histograms if client/server have different settings. Removing it deprecates quite a lot of code in builder.rs
| let upper = ((i as f64 + 1.0) * LN_RATIO).exp(); | ||
| writeln!( | ||
| w, | ||
| "confidence_resolve_latency_microseconds_bucket{{instance=\"{instance}\",le=\"{upper:.6e}\"}} {cumulative}" |
Contributor
Author
There was a problem hiding this comment.
Do we want the unit as a label rather than part of metric name. Not sure what's idiomatic.
Contributor
Author
There was a problem hiding this comment.
No. Unit in metric name is actually mandated. We could consider to switch to SI seconds though.
| } | ||
|
|
||
| message PrometheusSnapshotRequest { | ||
| string instance = 1; |
Contributor
Author
There was a problem hiding this comment.
Instance is just an id used to disambiguate the metrics from different wasm instances. I'm considering if we should also allow a "histogram ratio" option to control how many buckets are produced.
nicklasl
reviewed
Mar 11, 2026
nicklasl
reviewed
Mar 11, 2026
| err := s.maintenance(func(lr LocalResolver) error { | ||
| text, err := lr.PrometheusSnapshot() | ||
| if err != nil { | ||
| return err |
nicklasl
reviewed
Mar 11, 2026
| return current.get().prometheusSnapshot(); | ||
| } catch (ChicoryException e) { | ||
| handleFailure("prometheusSnapshot", e); | ||
| throw e; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR first does some refactoring/cleanup of the telemetry and then adds a method to each SDK to extract prometheus metrics.