test: add 45 missing resolver spec test cases#335
Merged
Conversation
This was referenced Mar 13, 2026
Add 45 new test cases and supporting state (13 flags, 11 segments, 11 bitsets). Remove 2 duplicate tests (variant_match, full_rollout_no_targeting_key). Add rust overrides for 10 behavioral divergences. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nicklasl
force-pushed
the
nicklasl/add-missing-spec-tests
branch
from
8a16b23 to
0d379b7
Compare
nicklasl
changed the title
andreas-karlsson
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.json+tests.json) fromepx-flags-resolverto close the conformance gapNew test coverage
Test plan
make test— all 45 new tests passcircular_segment_dependency,empty_range_rule,mat_matched_no_variant_for_rule)🤖 Generated with Claude Code