gh-4873: configurable Document.toJson() serialization for logging#4915
Open
rfelgent wants to merge 1 commit intospring-projects:mainfrom
Open
gh-4873: configurable Document.toJson() serialization for logging#4915rfelgent wants to merge 1 commit intospring-projects:mainfrom
rfelgent wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
rfelgent
commented
Mar 8, 2025
- You have read the Spring Data contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
Contributor
Author
|
Hi @mp911de , after looking into the code, I would like to discuss options with you.
If we want to put hands on it, my preference is option 3) otherwise option 4). What dou you think ? Furthermore, is there another way to discuss ideas and implementation details with you apart form comments in pull requests ? |
Member
|
There's some logging inside the MongoDB driver through the I think having a logger delegate seems a good starting point. It doesn't introduce any changes to type inheritance and having another |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.