Widen operator method parameters from Criteria to CriteriaDefinition#5171
Open
seonghyeoklee wants to merge 1 commit intospring-projects:mainfrom
Open
Widen operator method parameters from Criteria to CriteriaDefinition#5171seonghyeoklee wants to merge 1 commit intospring-projects:mainfrom
seonghyeoklee wants to merge 1 commit intospring-projects:mainfrom
Conversation
Update orOperator, norOperator, andOperator and their Collection overloads to accept CriteriaDefinition instead of Criteria. This allows mixing different CriteriaDefinition implementations such as Criteria and TextCriteria in logical operators. Closes spring-projectsgh-3895 Signed-off-by: seonghyeoklee <rfrg312@naver.com> Signed-off-by: seonghyeoklee <dltjdgur327@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
orOperator,norOperator,andOperatorand theirCollectionoverloads to acceptCriteriaDefinitioninstead ofCriteria. This allows mixing differentCriteriaDefinitionimplementations such asCriteriaandTextCriteriain logical operators.Closes gh-3895