Remove compiler warnings for spring-security-access

access/src/main/java/org/springframework/security/access/prepost/PrePostAdviceReactiveMethodInterceptor.java

@@ -145,6 +145,7 @@ public Object invoke(final MethodInvocation invocation) {
 			.map((r) -> (attr != null) ? this.postAdvice.after(auth, invocation, attr, r) : r));
 	}
 
+	@SuppressWarnings("unchecked")
 	private static <T extends Publisher<?>> @Nullable T proceed(final MethodInvocation invocation) {
 		try {
 			return (T) invocation.proceed();

access/src/main/java/org/springframework/security/acls/afterinvocation/AclEntryAfterInvocationCollectionFilteringProvider.java

@@ -111,6 +111,7 @@ public Object decide(Authentication authentication, Object object, Collection<Co
 		return returnedObject;
 	}
 
+	@SuppressWarnings({ "unchecked", "rawtypes" })
 	private Filterer getFilterer(Object returnedObject) {
 		if (returnedObject instanceof Collection) {
 			return new CollectionFilterer((Collection) returnedObject);

access/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java

@@ -50,6 +50,7 @@ class MessageExpressionConfigAttribute implements ConfigAttribute, EvaluationCon
 	 * @param authorizeExpression the {@link Expression} to use. Cannot be null
 	 * @param matcher the {@link MessageMatcher} used to match the messages.
 	 */
+	@SuppressWarnings("unchecked")
 	MessageExpressionConfigAttribute(Expression authorizeExpression, MessageMatcher<?> matcher) {
 		Assert.notNull(authorizeExpression, "authorizeExpression cannot be null");
 		Assert.notNull(matcher, "matcher cannot be null");

access/src/main/java/org/springframework/security/web/access/expression/DefaultWebSecurityExpressionHandler.java

@@ -41,6 +41,7 @@ public class DefaultWebSecurityExpressionHandler extends AbstractSecurityExpress
 	private String defaultRolePrefix = DEFAULT_ROLE_PREFIX;
 
 	@Override
+	@SuppressWarnings("deprecation")
 	protected SecurityExpressionOperations createSecurityExpressionRoot(@Nullable Authentication authentication,
 			FilterInvocation fi) {
 		FilterInvocationExpressionRoot root = new FilterInvocationExpressionRoot(() -> authentication, fi);

access/src/test/java/org/springframework/security/access/AuthenticationCredentialsNotFoundEventTests.java

@@ -29,6 +29,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class AuthenticationCredentialsNotFoundEventTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/AuthorizationFailureEventTests.java

@@ -32,6 +32,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class AuthorizationFailureEventTests {
 
 	private final UsernamePasswordAuthenticationToken foo = UsernamePasswordAuthenticationToken.unauthenticated("foo",

access/src/test/java/org/springframework/security/access/AuthorizedEventTests.java

@@ -29,6 +29,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class AuthorizedEventTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/SecurityConfigTests.java

@@ -27,6 +27,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class SecurityConfigTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/annotation/Jsr250MethodSecurityMetadataSourceTests.java

@@ -32,6 +32,7 @@
  * @author Luke Taylor
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class Jsr250MethodSecurityMetadataSourceTests {
 
 	Jsr250MethodSecurityMetadataSource mds;

access/src/test/java/org/springframework/security/access/annotation/Jsr250VoterTests.java

@@ -31,6 +31,7 @@
 /**
  * @author Luke Taylor
  */
+@SuppressWarnings("deprecation")
 public class Jsr250VoterTests {
 
 	// SEC-1443

access/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java

@@ -46,6 +46,7 @@
  * @author Ben Alex
  * @author Luke Taylor
  */
+@SuppressWarnings("deprecation")
 public class SecuredAnnotationSecurityMetadataSourceTests {
 
 	private SecuredAnnotationSecurityMetadataSource mds = new SecuredAnnotationSecurityMetadataSource();

access/src/test/java/org/springframework/security/access/expression/method/DefaultMethodSecurityExpressionHandlerTests.java

@@ -79,11 +79,13 @@ public void cleanup() {
 	}
 
 	@Test
+	@SuppressWarnings("deprecation")
 	public void setTrustResolverNull() {
 		assertThatIllegalArgumentException().isThrownBy(() -> this.handler.setTrustResolver(null));
 	}
 
 	@Test
+	@SuppressWarnings("deprecation")
 	public void createEvaluationContextCustomTrustResolver() {
 		setupMocks();
 		this.handler.setTrustResolver(this.trustResolver);
@@ -175,7 +177,7 @@ public void filterStreamWhenClosedThenUpstreamGetsClosed() {
 	@Test
 	public void createEvaluationContextSupplierAuthentication() {
 		setupMocks();
-		Supplier<Authentication> mockAuthenticationSupplier = mock(Supplier.class);
+		Supplier<Authentication> mockAuthenticationSupplier = mock();
 		given(mockAuthenticationSupplier.get()).willReturn(this.authentication);
 		EvaluationContext context = this.handler.createEvaluationContext(mockAuthenticationSupplier,
 				this.methodInvocation);

access/src/test/java/org/springframework/security/access/expression/method/ExpressionBasedPreInvocationAdviceTests.java

@@ -39,6 +39,7 @@
  * @since 5.2
  */
 @ExtendWith(MockitoExtension.class)
+@SuppressWarnings("deprecation")
 public class ExpressionBasedPreInvocationAdviceTests {
 
 	@Mock

access/src/test/java/org/springframework/security/access/expression/method/MethodExpressionVoterTests.java

@@ -34,7 +34,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
 
-@SuppressWarnings("unchecked")
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class MethodExpressionVoterTests {
 
 	private TestingAuthenticationToken joe = new TestingAuthenticationToken("joe", "joespass", "ROLE_blah");

access/src/test/java/org/springframework/security/access/expression/method/MethodSecurityExpressionRootTests.java

@@ -27,6 +27,7 @@
 import org.springframework.security.access.PermissionEvaluator;
 import org.springframework.security.access.expression.ExpressionUtils;
 import org.springframework.security.authentication.AuthenticationTrustResolver;
+import org.springframework.security.authorization.DefaultAuthorizationManagerFactory;
 import org.springframework.security.core.Authentication;
 
 import static org.mockito.ArgumentMatchers.any;
@@ -58,7 +59,9 @@ public void createContext() {
 		this.ctx = new StandardEvaluationContext();
 		this.ctx.setRootObject(this.root);
 		this.trustResolver = mock(AuthenticationTrustResolver.class);
-		this.root.setTrustResolver(this.trustResolver);
+		DefaultAuthorizationManagerFactory<MethodInvocation> authorizationManagerFactory = new DefaultAuthorizationManagerFactory<>();
+		authorizationManagerFactory.setTrustResolver(this.trustResolver);
+		this.root.setAuthorizationManagerFactory(authorizationManagerFactory);
 	}
 
 	@Test

access/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java

@@ -44,6 +44,7 @@
  * @author Luke Taylor
  * @since 3.0
  */
+@SuppressWarnings("deprecation")
 public class PrePostAnnotationSecurityMetadataSourceTests {
 
 	private PrePostAnnotationSecurityMetadataSource mds = new PrePostAnnotationSecurityMetadataSource(

access/src/test/java/org/springframework/security/access/intercept/AbstractSecurityInterceptorTests.java

@@ -32,6 +32,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class AbstractSecurityInterceptorTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java

@@ -38,7 +38,7 @@
  *
  * @author Ben Alex
  */
-@SuppressWarnings("unchecked")
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class AfterInvocationProviderManagerTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/InterceptorStatusTokenTests.java

@@ -34,6 +34,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class InterceptorStatusTokenTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/NullRunAsManagerTests.java

@@ -27,6 +27,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class NullRunAsManagerTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/RunAsImplAuthenticationProviderTests.java

@@ -31,6 +31,7 @@
 /**
  * Tests {@link RunAsImplAuthenticationProvider}.
  */
+@SuppressWarnings("deprecation")
 public class RunAsImplAuthenticationProviderTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/RunAsManagerImplTests.java

@@ -34,6 +34,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class RunAsManagerImplTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/RunAsUserTokenTests.java

@@ -29,6 +29,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class RunAsUserTokenTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/aopalliance/MethodSecurityInterceptorTests.java

@@ -65,7 +65,7 @@
  * @author Ben Alex
  * @author Rob Winch
  */
-@SuppressWarnings("unchecked")
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class MethodSecurityInterceptorTests {
 
 	private TestingAuthenticationToken token;

access/src/test/java/org/springframework/security/access/intercept/aopalliance/MethodSecurityMetadataSourceAdvisorTests.java

@@ -33,6 +33,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class MethodSecurityMetadataSourceAdvisorTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/intercept/aspectj/AspectJMethodSecurityInterceptorTests.java

@@ -62,6 +62,7 @@
  * @author Luke Taylor
  * @author Rob Winch
  */
+@SuppressWarnings("deprecation")
 public class AspectJMethodSecurityInterceptorTests {
 
 	private TestingAuthenticationToken token;

access/src/test/java/org/springframework/security/access/intercept/method/MapBasedMethodSecurityMetadataSourceTests.java

@@ -34,6 +34,7 @@
  * @author Luke Taylor
  * @since 2.0.4
  */
+@SuppressWarnings("deprecation")
 public class MapBasedMethodSecurityMetadataSourceTests {
 
 	private final List<ConfigAttribute> ROLE_A = SecurityConfig.createList("ROLE_A");

access/src/test/java/org/springframework/security/access/intercept/method/MethodInvocationPrivilegeEvaluatorTests.java

@@ -49,6 +49,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class MethodInvocationPrivilegeEvaluatorTests {
 
 	private TestingAuthenticationToken token;

access/src/test/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSourceTests.java

@@ -36,7 +36,7 @@
 /**
  * @author Luke Taylor
  */
-@SuppressWarnings({ "unchecked" })
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class DelegatingMethodSecurityMetadataSourceTests {
 
 	DelegatingMethodSecurityMetadataSource mds;

access/src/test/java/org/springframework/security/access/prepost/PostInvocationAdviceProviderTests.java

@@ -29,6 +29,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @ExtendWith(MockitoExtension.class)
+@SuppressWarnings("deprecation")
 public class PostInvocationAdviceProviderTests {
 
 	@Mock

access/src/test/java/org/springframework/security/access/prepost/PreInvocationAuthorizationAdviceVoterTests.java

@@ -29,6 +29,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @ExtendWith(MockitoExtension.class)
+@SuppressWarnings("deprecation")
 public class PreInvocationAuthorizationAdviceVoterTests {
 
 	@Mock

access/src/test/java/org/springframework/security/access/vote/AbstractAccessDecisionManagerTests.java

@@ -36,7 +36,7 @@
  *
  * @author Ben Alex
  */
-@SuppressWarnings("unchecked")
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class AbstractAccessDecisionManagerTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/vote/AbstractAclVoterTests.java

@@ -31,6 +31,7 @@
 /**
  * @author Luke Taylor
  */
+@SuppressWarnings("deprecation")
 public class AbstractAclVoterTests {
 
 	private AbstractAclVoter voter = new AbstractAclVoter() {

access/src/test/java/org/springframework/security/access/vote/AffirmativeBasedTests.java

@@ -40,6 +40,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class AffirmativeBasedTests {
 
 	private final List<ConfigAttribute> attrs = new ArrayList<>();

access/src/test/java/org/springframework/security/access/vote/AuthenticatedVoterTests.java

@@ -37,6 +37,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class AuthenticatedVoterTests {
 
 	private Authentication createAnonymous() {

access/src/test/java/org/springframework/security/access/vote/ConsensusBasedTests.java

@@ -35,6 +35,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class ConsensusBasedTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/vote/DenyAgainVoter.java

@@ -32,6 +32,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class DenyAgainVoter implements AccessDecisionVoter<Object> {
 
 	@Override

access/src/test/java/org/springframework/security/access/vote/DenyVoter.java

@@ -34,6 +34,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class DenyVoter implements AccessDecisionVoter<Object> {
 
 	@Override

access/src/test/java/org/springframework/security/access/vote/RoleHierarchyVoterTests.java

@@ -25,6 +25,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+@SuppressWarnings("deprecation")
 public class RoleHierarchyVoterTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/vote/RoleVoterTests.java

@@ -28,6 +28,7 @@
 /**
  * @author Luke Taylor
  */
+@SuppressWarnings("deprecation")
 public class RoleVoterTests {
 
 	@Test

access/src/test/java/org/springframework/security/access/vote/UnanimousBasedTests.java

@@ -35,6 +35,7 @@
  *
  * @author Ben Alex
  */
+@SuppressWarnings("deprecation")
 public class UnanimousBasedTests {
 
 	private UnanimousBased makeDecisionManager() {

access/src/test/java/org/springframework/security/acls/afterinvocation/AclEntryAfterInvocationCollectionFilteringProviderTests.java

@@ -44,7 +44,7 @@
 /**
  * @author Luke Taylor
  */
-@SuppressWarnings({ "unchecked" })
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class AclEntryAfterInvocationCollectionFilteringProviderTests {
 
 	@Test

access/src/test/java/org/springframework/security/acls/afterinvocation/AclEntryAfterInvocationProviderTests.java

@@ -48,7 +48,7 @@
 /**
  * @author Luke Taylor
  */
-@SuppressWarnings({ "unchecked" })
+@SuppressWarnings({ "unchecked", "deprecation" })
 public class AclEntryAfterInvocationProviderTests {
 
 	@Test