Exclude build output directories from nohttp source set#18928
Merged
rwinch merged 2 commits intospring-projects:mainfrom Mar 18, 2026
Merged
Exclude build output directories from nohttp source set#18928rwinch merged 2 commits intospring-projects:mainfrom
rwinch merged 2 commits intospring-projects:mainfrom
Conversation
ribafish
added a commit
to gradle/develocity-oss-projects
that referenced
this pull request
Mar 18, 2026
The :checkstyleNohttp task's source set includes build output directories, causing cache misses between consecutive builds (experiment 2). The nohttp source set scans **/build/** which changes between build 1 and build 2. Upstream fix: spring-projects/spring-security#18928 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
spring-projects-issues
added
the
status: waiting-for-triage
The checkstyleNohttp task scans the entire project tree for non-HTTPS URLs. Without excluding **/build/**, subproject build output directories generated during the first build become additional source inputs for subsequent builds, changing the cache key and causing cache misses. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Gasper Kojek <gkojek@gradle.com>
The kerberos-client/target and kerberos-test/target directories contain .keytab files generated during test execution. These directories only exist after the first build, causing a cache miss for checkstyleNohttp in subsequent builds since the source input set changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Gasper Kojek <gkojek@gradle.com>
ribafish
force-pushed
the
gk/fix-checkstyleNohttp-caching
branch
from
3ca23bb to
750aeea
Compare
Member
|
Thank you for the PR @ribafish I've marked this to be merged as soon as the build passes |
rwinch
added
in: build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkstyleNohttptask scans the entire project tree for non-HTTPS URLs**/build/**, subproject build output directories generated during the first build become additional source inputs for subsequent builds**/build/**to thenohttpsource exclusion list alongside the existingbuildSrc/build/**exclusionTest plan
checkstyleNohttpstill runs correctly (the excluded directories only contain build outputs, not source files)--build-cacheTested that caching now works for all cases here: https://github.com/gradle/develocity-oss-projects/actions/runs/23246860010