Add unless support to AdditionalRequiredFactorsBuilder#18939
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Add unless support to AdditionalRequiredFactorsBuilder#18939therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
In this commit, we are adding support for 'unless' to 'AdditionalRequiredFactorsBuilder'. This is useful if we want a specific user type or factor to disable MFA. Closes: spring-projectsgh-18925 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Mar 19, 2026
Comment on lines
+117
to
+124
| /** | ||
| * Customize the condition that determines if the required factors are skipped. | ||
| * @param condition a function that takes the current condition and returns the | ||
| * new condition | ||
| * @return the {@link AdditionalRequiredFactorsBuilder} to further customize | ||
| * @since 7.1 | ||
| */ | ||
| public AdditionalRequiredFactorsBuilder<T> withUnless( |
Contributor
Author
There was a problem hiding this comment.
For consistency, we'll add this method (since there's withWhen)
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we are adding support for 'unless' to 'AdditionalRequiredFactorsBuilder'. This is useful if we want a specific user type or factor to disable MFA.
Closes: gh-18925