fix(sqlite): support Tcl-style $param(...) syntax#944
Merged
Conversation
SQLite's $-prefixed placeholder follows Tcl variable syntax, allowing one or more '::'-separated suffixes and an optional '(...)' trailer. Closes sql-formatter-org#943
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
nene
added a commit
that referenced
this pull request
May 12, 2026
Collaborator
|
Released in v15.7.4 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #943.
SQLite's
$-prefixed parameter follows Tcl variable syntax, which allows one or more::-separated suffixes and an optional(...)trailer. Previously the formatter only accepted a bare identifier after$, so inputs like$p(x=y)were tokenized as$pfollowed by a parenthesized expression and re-emitted with an unwanted space.This moves SQLite's
$-parameter into a dialect-specific custom rule that matches the full Tcl syntax, while:and@continue to use the default named-parameter path.Before
After
Tests cover the existing
$namebehaviour as well as$p(x=y)and$foo::bar(extra).