Add a github action to publish to NPM.js.#236
Conversation
Fix package-lock.json was outdated.
|
|
.github/workflows/main.yml
Outdated
| - name: Build iOS (debug) | ||
| working-directory: ./reader-sdk-react-native-quickstart/ios | ||
| run: xcodebuild -workspace RNReaderSDKSample.xcworkspace -configuration Debug -scheme RNReaderSDKSample -destination "platform=iOS Simulator,OS=16.2,name=iPhone 14" | ||
| run: xcodebuild -workspace RNReaderSDKSample.xcworkspace -configuration Debug -scheme RNReaderSDKSample -destination "platform=iOS Simulator,OS=18.2,name=iPhone 16" |
There was a problem hiding this comment.
How stable are those version numbers? Can they be pulled from some more visible config file or similar?
Or is that the "still needs some config" from your summary?
There was a problem hiding this comment.
I think they'd need to be changed every 2 years or so, basically if iOS has a new major version every year, they stop shipping xcode with the n-2 simulator (so for 2024 which saw iOS 18 getting released, the new xcode version dropped iOS 16). I think we can pass latest for the platform parameter, but for the name which is the sim device, we need to pass a explicit value. I'll check if there's an alternative
fka3
left a comment
fka3
left a comment
There was a problem hiding this comment.
That check sounds slow, I can +1 this. But I bet two years from now we're trying to figure out where the hell that number is....
|
yea we shouldn't need to worry anymore, I changed it to take |
3 participants
Add a github action to publish to NPM.js.
Fix package-lock.json was outdated.
Summary
Add a new action in .github to publish to NPM.JS. This still needs some configuration in our repo, but it's the first step.
Related issues
N/A
Changelog
Added npm-publish-github-packages.yml.
Modified package-lock.json.
Test Plan
Run the steps in the GH action in my computer with the
--dry-runoption