Refactor desktop startup/shutdown ownership paths and remove duplicated UI validation logic#58
Draft
Copilot wants to merge 4 commits into
Draft
Refactor desktop startup/shutdown ownership paths and remove duplicated UI validation logic#58Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/sshcrack/led-matrix/sessions/bdbe02bc-f698-497c-a566-96788e972beb Co-authored-by: sshcrack <34072808+sshcrack@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sshcrack/led-matrix/sessions/bdbe02bc-f698-497c-a566-96788e972beb Co-authored-by: sshcrack <34072808+sshcrack@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sshcrack/led-matrix/sessions/bdbe02bc-f698-497c-a566-96788e972beb Co-authored-by: sshcrack <34072808+sshcrack@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sshcrack
May 9, 2026 17:52
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change targets code quality debt in the desktop entrypoint by removing manual lifetime management and duplicated logic in high-traffic initialization/UI code. It keeps behavior intact while making resource handling and argument conversion safer and easier to reason about.
Ownership and lifetime cleanup (RAII)
src_desktop/main.cppwithstd::unique_ptrfor app-level objects:SingleInstanceManagerWebsocketClientnew/deletecleanup paths tied to app exit.Windows argument conversion hardening
wWinMainUTF-16 → UTF-8 argv construction to use RAII containers (std::vector<std::string>,std::vector<char*>) instead of manual heap buffers.UI validation deduplication
Scope cleanup
react-web/package.jsonversion bump to keep this PR focused on the desktop refactor.