You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd be inclined to go with IProgress<T> instead of Action for new/async APIs - Progress<T> provides some handling of the SynchronizationContext. And perhaps make T := struct DownloadFileProgressReport { long BytesDownloaded } or similar so that e.g. another property could be added later without much friction. WDYT?
Also do you want to do the same for UploadFileAsync as well? I guess it could be added to
I'd be inclined to go with IProgress instead of Action for new/async APIs
Done. This required another overload for UploadFileAsync though. We can't make canOverride optional since that would make UploadAsync(stream, file) ambigous.
mus65
changed the title
SftpClient: add DownloadFileAsync overload with downloadCallback
SftpClient: add IProgress to DownloadFileAsync and UploadFileAsync
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1765