Conversation
BobAnkh
requested changes
Apr 13, 2026
Member
BobAnkh
left a comment
BobAnkh
left a comment
There was a problem hiding this comment.
Most of the code is fine; only some minor issues need to be fixed or explained.
src/model/delay_per_packet.rs
Outdated
|
|
||
| /// Sets the upper bound | ||
| /// | ||
| /// If the upper bound is not set, the upper bound will be the one of [`Delay`]. |
Member
There was a problem hiding this comment.
What do you mean by 'be the one of [Delay]'? I do think from the generation and settings, how we use upper_bound in uniform is not similar to how we do in normal distr. I prefer you to improve the comments.
BobAnkh
approved these changes
Apr 13, 2026
BobAnkh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
UniformDelayPerPacket, similar toNormalDelayPerPacketbut changed the distribution to uniform distribution.How Has This Been Tested
This has been tested in doc tests attached to the newly added structs and implementations.
Screenshots(optional)
Types of changes
This is a non-breaking change with only new features added.
Checklist
Other information