Fix DOCA OFED build #2044
Merged
Fix DOCA OFED build #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues: - fix path to push-ofed.yml missed from Ansible playbook refactor - disable Pulp auth proxy (deployed too late for DOCA DNF repository)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the Pulp authentication proxy for the ci-doca-builder environment to address a timing issue during the DOCA DNF repository setup. The change, setting stackhpc_repo_mirror_auth_proxy_enabled to false, is a clear and appropriate fix for the described problem.
However, the pull request description also mentions a fix for a path to push-ofed.yml, which does not appear to be included in the provided changes. Please ensure all intended changes are part of this pull request.
Alex-Welsh
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues: