CIS: skip enabling gpgcheck on all yum repos #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoteHue
added
bug
Alex-Welsh
previously approved these changes
Jan 6, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the CIS hardening rule that enforces GPG checks on all yum repositories to accommodate a specific repository (doca) that does not support it. While this resolves the immediate conflict, it introduces a security risk by disabling a critical verification step for all repositories. My review includes a suggestion for a more targeted and secure approach that addresses the repository conflict without weakening the overall system security.
Member
|
Reno would be nice but fine as it is |
This conflicts with our configured doca repos, which need gpgcheck disabled.
MoteHue
force-pushed
the
cis-disable-gpgcheck-rule
branch
from
b626b72 to
52b28d9
Compare
Alex-Welsh
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conflicts with our configured doca repos, which need gpgcheck disabled.