Remove use of ovn-octavia-provider fork #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix was merged in 2024.1 [1]. [1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/965800
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the configuration for a forked ovn-octavia-provider repository. According to the description, this is because a required bug fix has been merged into the upstream 2024.1 release, making the fork unnecessary. The change in etc/kayobe/kolla.yml correctly removes the custom source definitions. This is a clean and well-justified change that follows the good practice of preferring upstream sources. The implementation is correct and I have no suggestions for improvement.
Alex-Welsh
approved these changes
Jan 6, 2026
Member
|
Seems like we need a CI job to go through and just check the diff of branches against their upstream equivalent, to alert us when all our custom changes have merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix was merged in 2024.1 [1].
[1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/965800