Skip to content

Conversation

@priteau
Copy link
Member

@priteau priteau commented Jan 6, 2026

Bug fix was merged in 2025.1 [1].

[1] https://review.opendev.org/c/openstack/keystone/+/972248

@priteau priteau self-assigned this Jan 6, 2026
@priteau priteau requested a review from a team as a code owner January 6, 2026 19:18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the use of a forked Keystone repository, as the required bug fix is now in the upstream release. The change itself is just a removal of the source override in etc/kayobe/kolla.yml. While the change is correct, I've suggested adding a release note to properly document this dependency update for users, similar to how other such changes have been handled in this project.

I am having trouble creating individual review comments. Click here to see my feedback.

etc/kayobe/kolla.yml (138-141)

medium

While removing this forked repository is the correct action, this change should be accompanied by a release note to ensure users are aware of the update. A similar change for Magnum included one (see releasenotes/notes/use-upstream-magnum-86854beee69151f5.yaml). Please consider adding a release note for this change.

@Alex-Welsh Alex-Welsh merged commit 93ac06e into stackhpc/2025.1 Jan 7, 2026
21 of 22 checks passed
@Alex-Welsh Alex-Welsh deleted the keystone-fork-epoxy branch January 7, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants