Skip to content

Conversation

@Alex-Welsh
Copy link
Member

Remove check-review requirement. It also appears to be broken at the moment

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner November 27, 2025 13:13
@gemini-code-assist
Copy link

Summary of Changes

Hello @Alex-Welsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's CI/CD process by disabling the 'stackhpc/check-review' requirement. This action addresses a currently broken dependency, ensuring that the review workflow is not hindered by a non-functional check.

Highlights

  • Requirement Removal: The 'stackhpc/check-review' requirement has been removed from the project's configuration.
  • Reason for Removal: This requirement was removed because it appears to be broken and non-functional, hindering the review process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the stackhpc/check-review required status check for the stackhpc/2025.1 branch in the stackhpc-kayobe-config repository. The change is justified by the pull request description, which states that the check is currently broken. The modification in terraform/github/terraform.tfvars.json is correct and achieves the intended goal. The code change is sound and I have no further suggestions.

@stackhpc-ci
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @Alex-Welsh, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

Copy link
Member

@cityofships cityofships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙁

@Alex-Welsh
Copy link
Member Author

I've looked more at recent errors, and I'm not convinced it's really a Zuul problem, but regardless, they're failing at the moment so lets go ahead and revert as soon as possible

Recent logs

example failures [1] [2]

@Alex-Welsh Alex-Welsh merged commit a79fcbb into main Nov 27, 2025
4 checks passed
@Alex-Welsh Alex-Welsh deleted the disable-zuul-check branch November 27, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants