-
Notifications
You must be signed in to change notification settings - Fork 1
Disable Zuul check-review requirement #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Alex-Welsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's CI/CD process by disabling the 'stackhpc/check-review' requirement. This action addresses a currently broken dependency, ensuring that the review workflow is not hindered by a non-functional check. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the stackhpc/check-review required status check for the stackhpc/2025.1 branch in the stackhpc-kayobe-config repository. The change is justified by the pull request description, which states that the check is currently broken. The modification in terraform/github/terraform.tfvars.json is correct and achieves the intended goal. The code change is sound and I have no further suggestions.
Terraform Format and Style 🖌
|
cityofships
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙁
|
I've looked more at recent errors, and I'm not convinced it's really a Zuul problem, but regardless, they're failing at the moment so lets go ahead and revert as soon as possible |
Remove check-review requirement. It also appears to be broken at the moment