Invert ignored_releases#524
Conversation
This commit inverts the ignored_releases variable so we now assume all releases are ignored, unless specified. In the beginning, most forks we manage would be managed for most release. Over time that has changed, so it's more logical to just name all the branches that we do want to sync.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the release management logic by transitioning from an exclusion-based approach (ignored_releases) to an inclusion-based approach (synced_releases). It renames the global default_releases variable to maintained_releases across Ansible configurations, documentation, and validation scripts. The core logic in the repository sync task now calculates active releases using an intersection of maintained and synced releases. Review feedback recommends enhancing the Python validation script by ensuring type consistency for release versions, providing deterministic error output, and replacing assert statements with explicit exit codes to prevent validation from being bypassed in CI environments.
Alex-Welsh
force-pushed
the
invert-ignored-releases
branch
from
b46bced to
f160cab
Compare
1 participant
Instead of assuming all branches of a repo are synced, it makes more sense to assume they are ignored, and specify the ones we want to sync.
Added a CI test to make sure all synced_releases exist in maintained_releases