fix(registry-promo): adjust logic for isDefaultRegistry#1773
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the registry promo/meta-filter gating logic to correctly detect the built-in default registry using the registry type (instead of the registry name), aligning UI behavior with how registry configuration is represented in the API.
Changes:
- Update
isDefaultRegistrydetection to useregistryData.type(defaultvsurl/file/api) with a fallback for missingtype. - Update route tests to set
typein mock overrides instead of mutatingname. - Extend the registry-by-name MSW fixture to include
type: 'default'by default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
renderer/src/routes/(registry)/-registry.route.tsx |
Switches default-registry detection logic from name-based to type-based to drive promo visibility and meta-server filtering. |
renderer/src/routes/__tests__/registry.test.tsx |
Updates test overrides to validate behavior based on registry type instead of name. |
renderer/src/common/mocks/fixtures/registry_name/get.ts |
Adds type: 'default' to the default mocked registry response to reflect API shape. |
peppescg
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per title, we were checking name instead of type