Skip to content

fix: mitigate flaky tests on path reloading #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Molter73 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: mitigate flaky tests on path reloading #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_config_hotreload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def test_no_paths_then_add(fact, fact_config, monitored_dir, server):
# Remove all paths
config, config_file = fact_config
config['paths'] = []
reload_config(fact, config, config_file)
reload_config(fact, config, config_file, 1)

# Write to a file — should NOT produce events
fut = os.path.join(monitored_dir, 'test2.txt')
Expand All @@ -180,7 +180,7 @@ def test_no_paths_then_add(fact, fact_config, monitored_dir, server):

# Add paths back
config['paths'] = [f'{monitored_dir}/**/*']
reload_config(fact, config, config_file)
reload_config(fact, config, config_file, 1)

# Write to a file — should produce events
with open(fut, 'w') as f:
Expand Down Expand Up @@ -209,7 +209,7 @@ def test_paths_then_remove(fact, fact_config, monitored_dir, server):
# Remove all paths
config, config_file = fact_config
config['paths'] = []
reload_config(fact, config, config_file)
reload_config(fact, config, config_file, 1)

# Write to a file — should NOT produce events
with open(fut, 'w') as f:
Expand Down
Loading