Update all Rendezvous-specific functions access to private#258
Open
BowTiedRadone wants to merge 13 commits into
Open
Update all Rendezvous-specific functions access to private#258BowTiedRadone wants to merge 13 commits into
BowTiedRadone wants to merge 13 commits into
Conversation
BowTiedRadone
changed the title
BowTiedRadone
force-pushed
the
feat/priv-rv-fns
branch
from
36b9d76 to
f394c39
Compare
BowTiedRadone
requested review from
friedger,
hugo-stacks,
moodmosaic and
wileyj
moodmosaic
reviewed
May 1, 2026
Contributor
Author
|
This should be good enough to merge. Does anyone have cycles for another review round @friedger @hugo-stacks @moodmosaic @wileyj? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #257.
Changes
invariant-*), property tests (test-*), discard functions (can-*), andupdate-contextare nowdefine-private. The harness invokes them viasimnet.callPrivateFn(already exposed by@stacks/clarinet-sdk).RV_ACCESSconstant inshared.tsis the single source of truth for the access modifier per role; filters and test fixtures consume it instead of hardcoding"private".(public)→(private)).filterSutFunctionssimplified: trusts the access filter alone.Breaking
Contracts using the old conventions (
define-read-onlyinvariants,define-publictests) will silently produce "no functions found".